test: Added more benchmarks for the executor #2430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmachowinski
requested review from
ivanpauno,
hidmic and
wjwwood
as code owners
3 tasks
|
Should we add the events executor to this list of benchmarks? |
jmachowinski
force-pushed
the
more_bechmarks
branch
from
6994cf3 to
851ff29
Compare
|
@alsora I added the events executor to the cascaded test. Its around 10x faster then the other executors... Feel free to add it to more tests. Note some benchmark tests don't make sense for the events executor, like waitset rebuild. |
alsora
reviewed
Apr 12, 2024
|
Hi @jmachowinski, can you rebase your branch so we can start CI again and this merged? |
Signed-off-by: Janosch Machowinski <[email protected]>
jmachowinski
force-pushed
the
more_bechmarks
branch
from
851ff29 to
5529044
Compare
|
rebased |
|
|
@jmachowinski I think this needs a pass on linting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional benchmarks for the executors
@mjcarroll These are the benchmarks you requested in #2142.