Test case and fix for for https://github.com/ros2/rclcpp/issues/2652 #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmachowinski
force-pushed
the
executor_index_bug
branch
from
6906974 to
660ffaa
Compare
jmachowinski
changed the title
|
@luca-della-vedova @fmrico can you test this fix ? |
alsora
reviewed
Dec 18, 2024
| timer1_works = false; | ||
| timer2_works = false; | ||
| max_end_time = std::chrono::steady_clock::now() + std::chrono::milliseconds(100); | ||
| while(!timer1_works && !timer2_works) { |
There was a problem hiding this comment.
why do we keep checking timer2_works after calling timer2.reset(); ?
There was a problem hiding this comment.
To be sure, the first callback does not occur any more. Also there was code before, were I tried to figure out the order in the executor, but I gave up on that after reading the documentation of unordered map.
luca-della-vedova
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
I tried on the reproduction repo and this branch indeed fixes it!
added 3 commits
December 18, 2024 13:06
Signed-off-by: Janosch Machowinski <[email protected]>
Signed-off-by: Janosch Machowinski <[email protected]>
Signed-off-by: Janosch Machowinski <[email protected]>
jmachowinski
force-pushed
the
executor_index_bug
branch
from
660ffaa to
e3142d0
Compare
Sure!! testing... |
|
I have tested this PR against:
Everything is working now: LGTM 🔥 🚀 |
Signed-off-by: Francisco Martín Rico <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test case and fix for the bug #2652