Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chapters to FFProbe #416

Merged
merged 7 commits into from
Oct 5, 2023
Merged

Add chapters to FFProbe #416

merged 7 commits into from
Oct 5, 2023

Conversation

phillipfisher
Copy link
Contributor

I added the -show_chapters flag to the FFProbe invocation and added the Parsing code for it.

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (4a39e23) 74.65% compared to head (ed30b14) 74.20%.
Report is 1 commits behind head on main.

❗ Current head ed30b14 differs from pull request most recent head 21c02ba. Consider uploading reports for the commit 21c02ba to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
- Coverage   74.65%   74.20%   -0.45%     
==========================================
  Files         113      113              
  Lines        2837     2846       +9     
==========================================
- Hits         2118     2112       -6     
- Misses        719      734      +15     
Files Coverage Δ
FFMpegCore/FFProbe/FFProbe.cs 80.00% <100.00%> (ø)
FFMpegCore/FFMpeg/Builders/MetaData/ChapterData.cs 90.00% <0.00%> (-10.00%) ⬇️
FFMpegCore/FFProbe/MediaAnalysis.cs 91.62% <25.00%> (-3.12%) ⬇️
FFMpegCore/FFProbe/FFProbeAnalysis.cs 73.84% <12.50%> (-8.61%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosenbjerg
Copy link
Owner

Hey @phillipfisher,
Looks great! I've just added a single comment with a question :)

@rosenbjerg rosenbjerg merged commit 20a5b15 into rosenbjerg:main Oct 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants