Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Changed "Chapter" Modell #478

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

vortex852456
Copy link
Contributor

@vortex852456 vortex852456 commented Oct 16, 2023

Because "Id", "Start" and "End" returned by ffprobe can contain values larger than Int32.MaxValue

…by ffprobe can contain values larger than Int32.MaxValue
@codecov-commenter
Copy link

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (f8407bc) 74.31% compared to head (df123bb) 74.60%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   74.31%   74.60%   +0.28%     
==========================================
  Files         113      115       +2     
  Lines        2854     2910      +56     
==========================================
+ Hits         2121     2171      +50     
- Misses        733      739       +6     
Files Coverage Δ
FFMpegCore/FFMpeg/FFMpegArguments.cs 83.56% <100.00%> (+2.91%) ⬆️
FFMpegCore/FFMpeg/FFMpegMultiOutputOptions.cs 84.61% <84.61%> (ø)
FFMpegCore/FFProbe/FFProbeAnalysis.cs 73.84% <0.00%> (ø)
FFMpegCore/FFMpeg/Arguments/OutputTeeArgument.cs 71.87% <71.87%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vortex852456
Copy link
Contributor Author

@codecov-commenter I just changed property types so my change should not impact any coverage.

@rosenbjerg rosenbjerg merged commit eb221c3 into rosenbjerg:main Oct 25, 2023
3 checks passed
@rosenbjerg
Copy link
Owner

Nice. Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants