Make cachedir relative to installroot #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like `logdir`, the `cachedir` and `system_cachedir` configuration
options should be treated as relative to the installroot, unless
specified is specified on the command line, e.g. via
--setopt=cachedir=/path/to/cachedir. This is the behavior of the
cachedir with DNF 4.
Currently, the host cache directory is used by default, conflicting with
what our docs say (man 7 dnf5-installroot):
"cachedir, log files, releasever, and gpgkey are taken from or stored
in the installroot."
After this change, the default system_cachedir is
$installroot/var/cache/libdnf5, which is consistent with the docs.
For https://bugzilla.redhat.com/show_bug.cgi?id=2256945
evan-goode
force-pushed
the
evan-goode/installroot-cachedir
branch
from
1fb6350 to
834718c
Compare
|
Related: #754 |
|
Works fine. Tested with: |
|
I mean, together with mock-core-configs from: rpm-software-management/mock#1282 |
jan-kolarik
approved these changes
Jan 9, 2024
4 tasks
Alright, I created rpm-software-management/ci-dnf-stack#1436 since I think this should be merged quickly. |
Merged
via the queue into
rpm-software-management:main
with commit Jan 9, 2024
58e0f11
5 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like
logdir, thecachedirconfiguration option should be treated as relative to the installroot, unless it is specified on the command line via--setopt=cachedir=/path/to/cachedir. This is the behavior of the cachedir with DNF 4.Currently, the host cache directory is used by default, conflicting with what our docs say (man 7 dnf5-installroot):
After this change, the default cachedir is
$installroot/var/cache/libdnf5, which is consistent with the docs.For https://bugzilla.redhat.com/show_bug.cgi?id=2256945.