Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illuminator support for IPC-HFW2439SP-SA-LED-S2 #430

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

adobrotvorskiy
Copy link
Contributor

Added check for Lighing_V2 support and API call if it supported in init.py

Also edit check for infrared light support. IPC-HFW2439SP-SA-LED-S2 has no infrared light but it was found by integration.

@rroller
Copy link
Owner

rroller commented Nov 28, 2024

Thank you!

@rroller rroller merged commit 8615295 into rroller:main Nov 28, 2024
2 of 3 checks passed
@Pastaloverzzz
Copy link
Contributor

Pastaloverzzz commented Nov 28, 2024

After this update i got a depreciation warning. Not sure if this is the problem but since it seems to be something about the light..

I al Running 2024.12.b1 core but didn't get a error before i updated to the latest dahua version.

Logger: homeassistant.components.light
Bron: components/light/__init__.py:1329
integratie: Licht (documentatie, problemen)
Eerst voorgekomen: 22:59:08 (4 gebeurtenissen)
Laatst gelogd: 22:59:18

Entity None (<class 'custom_components.dahua.light.DahuaIlluminator'>) is using deprecated supported features values which will be removed in HA Core 2025.1. Instead it should use <LightEntityFeature: 0> and color modes, please create a bug report at https://github.com/rroller/dahua/issues and reference https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation

AND ALSO

Logger: homeassistant.components.light
Bron: components/light/__init__.py:1276
integratie: Licht (documentatie, problemen)
Eerst voorgekomen: 22:59:08 (4 gebeurtenissen)
Laatst gelogd: 22:59:18

None (<class 'custom_components.dahua.light.DahuaIlluminator'>) does not set supported color modes, this will stop working in Home Assistant Core 2025.3, please create a bug report at https://github.com/rroller/dahua/issues

@mrzv
Copy link

mrzv commented Dec 1, 2024

Is this related to, or can it help #321?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants