Engine and query serialization #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented `serde::Serialize` and `serde::Deserialize` for `MainEngine` in rsonpath-lib, and `JsonPathQuery` in rsonpath-syntax with all of its constituent substructs. The `serde` dependency is guarded behind an optional feature. To properly proptest this feature `rsonpath-lib` needs access to the arbitrary query generation from `rsonpath-syntax`. The cleanest way to do this is to extract the logic to a separate crate, giving rise to `rsonpath-syntax-proptest`. The serialization format is not stable, as the `Automaton` is expected to evolve. Thus, serialization includes a version and deserialization will fail if the version disagrees. Ref: #624
Added snapshot tests based on `insta` to both the rsonpath-syntax and rsonpath-lib serialization features. Ref: #624
V0ldek
changed the title
|
@azoyan Does this suit your usecase? |
Yes. It is perfect. I am completely satisfied already at the previous step, having implemented serialization for my wrapper. But maybe it is worth asking someone else. Invite other developers to the discussion. So that in the future you do not break the binary data format if something needs to be changed. |
|
The binary format will definitely be broken at some point, e.g. #117 has to change the way we represent labels internally while #154 and #156 will most likely fundamentally change the Automaton representation. Once we hit 1.0.0 there'll be some stability guarantees, but that's a long way away with my current dev resources of "me during a weekend" lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Implemented
serde::Serializeandserde::DeserializeforMainEnginein rsonpath-lib, andJsonPathQueryin rsonpath-syntax with all of its constituent substructs.The
serdedependency is guarded behind an optional feature.Issue
Resolves: #624
Obsoletes: #625
Checklist
All of these should be ticked off before you submit the PR.
just verifylocally and it succeeded.