feat: .section.level{N} don't need margin-top (#443)

rstudio · Oct 5, 2023 · 2a481f9 · 2a481f9
1 parent f71bc1f
commit 2a481f9
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # flexdashboard (development version)
 
+* flexdashboard now prevents top margin from being applied to boxes created with flexdashboard's markdown syntax when Bootstrap 5 is used. (#443)
+
 # flexdashboard 0.6.2
 
 ## New features

diff --git a/inst/www/flex_dashboard/flexdashboard.min.css b/inst/www/flex_dashboard/flexdashboard.min.css
diff --git a/inst/www/flex_dashboard/flexdashboard.scss b/inst/www/flex_dashboard/flexdashboard.scss
@@ -45,6 +45,11 @@ $custom-nav-color: rgba($custom-nav-active-color, 0.6) !default;
   }
 }
 
+@for $idx from 1 through 6 {
+  :where(.section.level#{$idx}) {
+    margin-top: 0;
+  }
+}
 
 /*
  Dashboard CSS derives from Keen IO Dashboards

diff --git a/tests/testthat/test_built_css.R b/tests/testthat/test_built_css.R
@@ -16,7 +16,10 @@ test_that("flexdashboard.min.css has been built", {
   pkg_css_file <- system.file("www/flex_dashboard/flexdashboard.min.css", package = "flexdashboard")
   pkg_css <- readLines(pkg_css_file)
 
-  # If this fails, that means that tools/updateShinyCSS.R needs to be run.
-  expect_identical(new_css, pkg_css)
+  # If this fails, that means that tools/updateCSS.R needs to be run.
+  expect_identical(
+    new_css,
+    pkg_css,
+    label = "Pre-built CSS is out of date, please run `Rscript tools/updateCSS.R`.\n"
+  )
 })
-