Show renderDataTable deprecation message by default #3718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The description of "Superseded" might make this difficult (see #3627 (comment) ). |
jcheng5
force-pushed
the
renderdatatable-deprecation
branch
from
de8153c to
acbd1ed
Compare
|
Hmmm, I used the GitHub button to rebase the branch against main and now CI is failing. Edit: Fixed, the problem was with the GHA workflow, nothing to do with this PR. |
|
Is this PR still ongoing? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3627.
shiny::renderDataTablehas been deprecated since shiny 0.11.1, but the deprecation warning was only shown in dev mode.shiny::renderDataTableandshiny::dataTableOutputin favour of the DT equivalents, allowing shiny to remove its dependency on DataTables.