Canonicalize IPv6 address text form in rdata. #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwelling
approved these changes
Nov 15, 2023
|
I went light because it's impossible for the system to accept a non-canonical IPv4 address, but if I went for full consistency I'd do it for IPv4 and dns.inet too. I'm glad to add it. |
|
I agree that an IPv4 |
rthalley
force-pushed
the
canonicalize-ipv6
branch
from
467e543 to
3fbf4d8
Compare
bwelling
approved these changes
Nov 15, 2023
Comment on lines
+191
to
+197
| try: | ||
| return dns.ipv6.canonicalize(text) | ||
| except Exception: | ||
| try: | ||
| return dns.ipv4.canonicalize(text) | ||
| except Exception: | ||
| raise ValueError |
There was a problem hiding this comment.
It doesn't matter at all, but all of the other code in this module tries IPv4 first.
|
|
||
| Raises ``dns.exception.SyntaxError`` if the text is not valid. | ||
| """ | ||
| # Note that inet_aton() only accepts canonial form, but we still run through |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dnspython did not canonicalize the textual form of IPv6 address in rdata read from text format, which could possibly cause problems in application software if the address was used as a key.