Adds nullish coalescing to output of Aws::SQS::Client#receive_message to an empty array

[mkeemon]

Fixes #752 due to change in behavior of aws-sdk-sqs (aws/aws-sdk-ruby#2947)

• This adds a default value of [] to all invocations of Aws::SQS::Client#receive_message
• The underlying behavior in the AWS Ruby SDK appears to have been patched, but this will prevent regressions in the future should something similar happen again

[mkeemon]

@phstc any ideas on why moto and Aws::SQS::Client are now at odds? Moto is returning XML while the client expects JSON. Did you run into any similar issues when creating the newest release a few weeks ago?

Moto

• Python version: 3.12.0
• Moto Version: 4.2.9

AWS Client

• aws-sdk-core: 3.187.1
• aws-sdk-sqs: 1.67.0

Failure/Error: Shoryuken::Client.sqs.delete_queue(queue_url: queue_url)
     Aws::Json::ParseError:
       unexpected token at '<DeleteQueueResponse><ResponseMetadata><RequestId>qYSGBzaVm7ABwMZ9tT15MD8XDLycSkezkGhzDSFKhCmgCc68O3re</RequestId></ResponseMetadata></DeleteQueueResponse>'

$ pip show moto
Name: moto
Version: 4.2.9
Summary: 
Home-page: https://github.com/getmoto/moto
Author: Steve Pulec
Author-email: "[email protected]"
License: Apache License 2.0
Location: /usr/local/lib/python3.12/site-packages
Requires: boto3, botocore, cryptography, Jinja2, python-dateutil, requests, responses, werkzeug, xmltodict

[phstc]

@mkeemon thanks for checking it. The last release passed ✅ fine #751

I'm wondering if there's something with the AWS change, and now we need to specify the type to be JSON instead of XML somewhere here.

I couldn't find an option on the initializer to configure that though.

[mkeemon]

What if I am already on the latest AWS SDK version, but my open sourced solution does not support JSON?
You must change your SDK version to the version previous to what you are using. See How do I get started with AWS JSON protocols for Amazon SQS? for more infomation. AWS SDK versions listed in How do I get started with AWS JSON protocols for Amazon SQS? uses JSON wire protocol for Amazon SQS APIs. If you change your AWS SDK to the previous version, your Amazon SQS APIs will use the AWS query.

https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-json-faqs.html

It looks like 1.67.0 of aws-sdk-sqs, which came out a couple weeks ago, moves to JSON. I'll try pinning the version to 1.66.0 1.65.0 for now and open up an issue in Moto repo to migrate the responses to JSON.

Edit: 1.66.0 introduces JSON - 1.65.0 works with XML + Moto

[phstc]

@mkeemon great find! Re-running tests. Thanks for helping with this. I really appreciate it.

[mkeemon]

@phstc done and done!

[mscrivo]

I'm a bit curious, why the need to pin the version of aws sdk for tests if this PR fixes the issue with the newer versions? Won't that just prevent finding issues with newer versions of the sdk in the future?

[mkeemon]

@mscrivo This PR was merged slightly before the one in Moto. I didn't realize just how quickly the Moto team would take action on this. We should be able to remove the strict versioning in the Gemfile now.

Edit: It doesn't look like Moto has cut a new release that contains these changes just yet.

[phstc]

@mkeemon version 6.1.1 is out with this PR! Thank you 🎉