Scope the shoryuken context to the current fiber. #765
Conversation
|
This PR is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. |
|
@phstc do you have time to review? Thanks! |
|
Hi @ioquatix Sorry, I'm a bit out of the loop here. Are there any breaking changes here?
Asking in case this is good to go as a patch version or if there is any concern with a specific version of Ruby or Rails. |
|
In general, I don't believe this is a breaking change. |
|
This PR is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. |
|
This PR was closed because it hasn't seen activity for a while. |
|
@phstc any update? |
|
@ioquatix, Unfortunately, I'm not currently active with Ruby or Shoryuken. I'm mainly merging maintenance pull requests. It would be nice to have input from an active user. Can you try the Slack channel? https://join.slack.com/t/shoryuken/shared_invite/zt-19xjq3iqc-KmoJ6eU6~qvZNqcLzIrjww |
|
This PR is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. |
|
This PR was closed because it hasn't seen activity for a while. |
I'd like to start a discussion about how to more efficiently manage the context during logging.
This exposes a proper interface for getting the current context.
In addition, I'd like to understand, do you expect if someone creates child fibers or threads, that the context should be shared? e.g. map-reduce / fan-out style workloads. I'm assuming the answer should be yes, but I'd like to know your opinion. In that case, it's better to use
Fiber#storage.