Skip to content

Commit

Permalink
ssl: fix flaky test case test_ctx_client_session_cb_tls13_exception
Browse files Browse the repository at this point in the history
In the test case, the client raises an exception in the session_new_cb
and may not cleanly close the connection. Let's ignore exceptions raised
at the server side.

Fixes: #828
  • Loading branch information
rhenium committed Dec 20, 2024
1 parent f4e7c4b commit 210ba03
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion test/openssl/test_ssl_session.rb
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,11 @@ def test_ctx_client_session_cb_tls13_exception
omit "TLS 1.3 not supported" unless tls13_supported?
omit "LibreSSL does not call session_new_cb in TLS 1.3" if libressl?

start_server do |port|
server_proc = lambda do |ctx, ssl|
readwrite_loop(ctx, ssl)
rescue SystemCallError, OpenSSL::SSL::SSLError
end
start_server(server_proc: server_proc) do |port|
ctx = OpenSSL::SSL::SSLContext.new
ctx.min_version = :TLS1_3
ctx.session_cache_mode = OpenSSL::SSL::SSLContext::SESSION_CACHE_CLIENT
Expand Down

0 comments on commit 210ba03

Please sign in to comment.