Use X509_ALGOR_get0() accessor for X509_ALGOR #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the struct is currently still public in OpenSSL, there has been an accessor since OpenSSL 0.9.8h. It would be nice if this accessor could be used so that the struct can be made opaque at some point in the future.
|
Of course there had to be a const change in the OpenSSL 1.1 cycle. I should have thought of that. Sorry about hat. Presumably this means that we need a define that is const for OpenSSL >= 1.1 and empty otherwise. This is becoming more cumbersome than I'd hoped it to be... |
botovq
changed the title
|
Makes sense to me. I'm hoping to remove OpenSSL 1.0.2 support in our next release as the last significant user of it (RHEL 7 - on which we still test Ruby on rubyci.org) will reach EOL next year. Since this is not urgent, let's merge it after that. |
|
On Wed, Oct 25, 2023 at 01:10:27PM -0700, Kazuki Yamaguchi wrote:
Makes sense to me.
I'm hoping to remove OpenSSL 1.0.2 support in our next release as the last significant user of it (RHEL 7 - on which we still test Ruby on rubyci.org) will reach EOL next year. Since this is not urgent, let's merge it after that.
Ok, great. Then I'll not ponder further complications. Thank you!
|
botovq
changed the title
|
@rhenium, what is the status here? It would be really nice if this could land now that RHEL 7 is EOL and if I could make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the struct is currently still public in OpenSSL, there has been an accessor since OpenSSL 0.9.8h. It would be nice if this accessor could be used so that the struct can be made opaque at some point in the future.