Revert openssl dir workaround on TruffleRuby #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refix on TruffleRuby" * This reverts commit ca738e7. * No longer needed since oracle/truffleruby#3170 was fixed.
eregon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is only in truffleruby-head, not yet in a release.
However, it seems truffleruby release is only used on ubuntu-22.04 in CI, where it works fine because anyway OpenSSL is picked: https://github.com/eregon/openssl/actions/runs/7060198654/job/19219283155#step:9:34
So it seems fine to merge this now and no need to wait for the 24.0 release.