Merge pull request #3019 from eileencodes/add-contains-splat-flag

Add `contains_splat` flag
ruby · Aug 27, 2024 · a9fdd90 · a9fdd90
2 parents 54b3937 + 5be97a7
commit a9fdd90
Show file tree

Hide file tree

Showing 14 changed files with 40 additions and 34 deletions.
diff --git a/config.yml b/config.yml
@@ -651,6 +651,8 @@ flags:
         comment: "if arguments contain keywords"
       - name: CONTAINS_KEYWORD_SPLAT
         comment: "if arguments contain keyword splat"
+      - name: CONTAINS_SPLAT
+        comment: "if arguments contain splat"
     comment: Flags for arguments nodes.
   - name: ArrayNodeFlags
     values:

diff --git a/src/prism.c b/src/prism.c
@@ -2062,6 +2062,10 @@ pm_arguments_node_arguments_append(pm_arguments_node_t *node, pm_node_t *argumen
 
     node->base.location.end = argument->location.end;
     pm_node_list_append(&node->arguments, argument);
+
+    if (PM_NODE_TYPE_P(argument, PM_SPLAT_NODE)) {
+        pm_node_flag_set((pm_node_t *) node, PM_ARGUMENTS_NODE_FLAGS_CONTAINS_SPLAT);
+    }
 }
 
 /**

diff --git a/test/prism/snapshots/arrays.txt b/test/prism/snapshots/arrays.txt
diff --git a/test/prism/snapshots/constants.txt b/test/prism/snapshots/constants.txt
diff --git a/test/prism/snapshots/method_calls.txt b/test/prism/snapshots/method_calls.txt
diff --git a/test/prism/snapshots/methods.txt b/test/prism/snapshots/methods.txt
diff --git a/test/prism/snapshots/return.txt b/test/prism/snapshots/return.txt
diff --git a/test/prism/snapshots/unparser/corpus/literal/assignment.txt b/test/prism/snapshots/unparser/corpus/literal/assignment.txt
diff --git a/test/prism/snapshots/unparser/corpus/literal/send.txt b/test/prism/snapshots/unparser/corpus/literal/send.txt
diff --git a/test/prism/snapshots/unparser/corpus/literal/since/32.txt b/test/prism/snapshots/unparser/corpus/literal/since/32.txt
diff --git a/test/prism/snapshots/whitequark/args_args_star.txt b/test/prism/snapshots/whitequark/args_args_star.txt
diff --git a/test/prism/snapshots/whitequark/args_star.txt b/test/prism/snapshots/whitequark/args_star.txt
diff --git a/test/prism/snapshots/whitequark/forwarded_argument_with_restarg.txt b/test/prism/snapshots/whitequark/forwarded_argument_with_restarg.txt
diff --git a/test/prism/snapshots/whitequark/forwarded_restarg.txt b/test/prism/snapshots/whitequark/forwarded_restarg.txt