Check for a semicolon or a newline after the inheritance operator #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddnewton
requested changes
Sep 20, 2023
src/yarp.c
Outdated
| @@ -12254,7 +12254,12 @@ parse_expression_prefix(yp_parser_t *parser, yp_binding_power_t binding_power) { | |||
| } | |||
|
|
|||
| yp_parser_scope_push(parser, true); | |||
| accept2(parser, YP_TOKEN_NEWLINE, YP_TOKEN_SEMICOLON); | |||
| if ((inheritance_operator.type != YP_TOKEN_NOT_PROVIDED) && !accept2(parser, YP_TOKEN_NEWLINE, YP_TOKEN_SEMICOLON)) { | |||
There was a problem hiding this comment.
You should be able to leverage expect2 here
kddnewton
approved these changes
Sep 21, 2023
|
@haldun can you rebase off |
|
@haldun instead of merging in |
haldun
force-pushed
the
haldun/check-semicolon-after-inheritance-op
branch
2 times, most recently
from
e50ad9f to
135ec74
Compare
|
Rebased in 135ec74 |
kddnewton
approved these changes
Sep 26, 2023
haldun
force-pushed
the
haldun/check-semicolon-after-inheritance-op
branch
3 times, most recently
from
f6817e9 to
4d66066
Compare
|
Oh man sorry @haldun another rebase necessary... |
haldun
force-pushed
the
haldun/check-semicolon-after-inheritance-op
branch
from
4d66066 to
0326ba6
Compare
|
rebased in 0326ba6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1544