encourage the compiler to compile lex_keyword
more efficiently
#1576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while profiling on x86-64 Linux that
strlen
was coming up awfully high on the profile and traced it tolex_keyword
:lex_keyword
.lex_keyword
without adding theinline
keyword. Clang on my arm64 mac already inlines this function withoutinline
, but this code is hot enough that I think it's worth giving an explicit hint to the compiler about what it should do.These changes speed up parsing a subset of Stripe's codebase by 4-5%. Each change described above is responsible for about half of that speedup.