Add full_name to ConstantPathNode and ConstantPathTargetNode
#1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ahh yeah these methods should go in node_ext.rb |
vinistock
force-pushed
the
vs/add_full_name_to_constant_path
branch
from
30c98be to
f53f3b2
Compare
kddnewton
requested changes
Oct 4, 2023
There was a problem hiding this comment.
I added a couple of suggestions that I think will make this easier to maintain.
Right now we're duplicating the logic to extract the full name between the target and the path nodes. If we share it, it will only be in one place, which is slightly nicer.
I'd like to also split up the logic between extracting the names versus joining them with ::. I've seen a couple of use cases where we want just the symbols, and it'll be easier if we provide them without having to split on :: again.
Also, would you mind adding documentation for these methods?
vinistock
force-pushed
the
vs/add_full_name_to_constant_path
branch
from
9e30d43 to
d506704
Compare
vinistock
commented
Oct 5, 2023
vinistock
force-pushed
the
vs/add_full_name_to_constant_path
branch
from
d506704 to
375234f
Compare
kddnewton
reviewed
Oct 5, 2023
lib/prism/node_ext.rb
Outdated
| @@ -52,4 +52,48 @@ def options | |||
| o | |||
| end | |||
| end | |||
|
|
|||
| class ConstantReadNode < Node | |||
| # Returns the list of parts for the full name of this constant. For example: ["Foo"] | |||
There was a problem hiding this comment.
Last thing, these examples should have symbols in the arrays
vinistock
force-pushed
the
vs/add_full_name_to_constant_path
branch
from
375234f to
b390553
Compare
kddnewton
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
full_nameto bothConstantPathNodeandConstantPathTargetNode, so that one can easily figure out the complete name of the constant being referenced.