Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing parenthesis in Location#pretty_print #1621

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Remove trailing parenthesis in Location#pretty_print #1621

merged 1 commit into from
Oct 4, 2023

Conversation

gazayas
Copy link
Contributor

@gazayas gazayas commented Oct 4, 2023

Currently when calling location from a node, the class is called with a trailing parenthesis. This change was introduced in #1549.

Before

[1] pry(main)> program_node.location
=> (1,0)-(2,6))

After

[1] pry(main)> program_node.location
=> (1,0)-(2,6)

@gazayas gazayas mentioned this pull request Oct 4, 2023
Closed
@kddnewton kddnewton merged commit 10cdcc2 into ruby:main Oct 4, 2023
46 checks passed
@gazayas gazayas deleted the fixes/location-output branch October 4, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kddnewton kddnewton kddnewton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gazayas @kddnewton