Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cargo fmt #1736

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Use cargo fmt #1736

merged 1 commit into from
Oct 26, 2023

Conversation

ianks
Copy link
Contributor

@ianks ianks commented Oct 25, 2023

Consistent formatting is nice, so let's enable it. I tried to configure rustfmt.toml to minimize big diffs to keep the original struct of the code as much as possible, since the default settings made a very noisy diff.

@kddnewton
Copy link
Collaborator

Generally +1 on this, but it looks like it's missing from the dependencies and also maybe a config file is missing?

@ianks
Copy link
Contributor Author

ianks commented Oct 25, 2023

Generally +1 on this, but it looks like it's missing from the dependencies and also maybe a config file is missing?

  • Forgot to commit the config files. Fixed.
  • No dependency is needed since cargo fmt is a built in.

@ianks
Copy link
Contributor Author

ianks commented Oct 26, 2023

I switched up the rustfmt.toml files somehow I guess? Anyway, fixed now.

@kddnewton kddnewton merged commit af51fb7 into ruby:main Oct 26, 2023
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants