Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdlib: csv: Add types for Array#to_csv and String#parse_csv #2099

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

tk0miya
Copy link
Contributor

@tk0miya tk0miya commented Nov 26, 2024


%a{annotate:rdoc:skip}
class Array[unchecked out Elem] < Object
# Equivalent to CSV::generate_line(self, options)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source code has docs, but opted out. Opened a PR to include them to the doc. ruby/csv#322

@soutaro
Copy link
Member

soutaro commented Dec 19, 2024

Confirmed the rbs annotate replaces the docs if it runs with the lates release of csv where the :nodoc: is deleted.
So, merging this. The release of ruby with updated csv-gem will fix the documentation issue finally.

@soutaro soutaro enabled auto-merge December 19, 2024 03:15
@soutaro soutaro added this to the RBS 3.8 milestone Dec 19, 2024
@soutaro soutaro added this pull request to the merge queue Dec 19, 2024
Merged via the queue into ruby:master with commit 55cede4 Dec 19, 2024
19 checks passed
@tk0miya tk0miya deleted the csv/Array.to_csv branch December 19, 2024 03:23
@soutaro soutaro added the Released PRs already included in the released version label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

2 participants