Improve Mac ARM (Apple Silicon) support #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch aims to close the issue rubycdp#421 by doing the following: 1. Only including the `--disable-gpu` flag when running on Windows as it is not needed on other platforms and it causes issues on Mac ARM. 2. Adding the `--use-angle=metal` flag when running on Mac ARM so the browser uses the Metal API instead of OpenGL. Close rubycdp#421
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aims to close the issue #421 by doing the following:
--disable-gpuflag when running on Windows as it is not needed on other platforms and it causes issues on Mac ARM.--use-angle=metalflag when running on Mac ARM so the browser uses the Metal API instead of OpenGL.Close #421