Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tea.xyz spam packages impact blog post #187

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Add tea.xyz spam packages impact blog post #187

merged 5 commits into from
Apr 17, 2024

Conversation

mensfeld
Copy link
Member

PR with a short article about the recent surge in empty packages, explaining why they were there, what we did, and why ppl should not do it again.

I omitted the exact gems' names as well as account details so as not to "shame" the author.

@mensfeld mensfeld self-assigned this Apr 14, 2024
@simi
Copy link
Member

simi commented Apr 14, 2024

Looks ok, just please refer about RubyGems.org (as a service), not about RubyGems. Also it would make sense to include full tea.xyz service name everytime mentioned (sometimes just tea is used).

@mensfeld
Copy link
Member Author

@simi updated 🙏

@simi
Copy link
Member

simi commented Apr 14, 2024

Also sometimes service is mentioned in plaintext tea.xyz, sometimes as tea.xyz. Is that intended?

Copy link
Member

@martinemde martinemde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small edits. What do you think about explaining that the result of these actions is probably losing access to a gem you maintain. It makes it clear that the risk of benefiting from tea.xyz is also maybe losing that benefit entirely.

I also wonder if we should clarify whether tea.xyz is explicitly allowed as long as you don't do any manipulation or spamming. Adding a paragraph to that effect would probably be a good clarification.

@mensfeld mensfeld requested a review from simi April 16, 2024 07:41
Copy link
Member

@martinemde martinemde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to publish, imho

@mensfeld mensfeld merged commit 0c0816f into master Apr 17, 2024
2 checks passed
@mensfeld mensfeld deleted the tea-xyz-impact branch April 17, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants