Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rails to security 7.0.3.1 update. #3145

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Update Rails to security 7.0.3.1 update. #3145

merged 1 commit into from
Jul 14, 2022

Conversation

simi
Copy link
Member

@simi simi commented Jul 13, 2022

Dependabot is on holidays, I was asked to keep dependencies updated meanwhile. 😃

@simi simi requested a review from sonalkr132 July 13, 2022 00:19
@simi simi marked this pull request as draft July 13, 2022 00:27
@simi simi mentioned this pull request Jul 13, 2022
Closed
@simi
Copy link
Member Author

simi commented Jul 13, 2022

We can't update I18n gem due to breaking change in 1.11.0 (ruby-i18n/i18n#630 (comment)), I have manually prepared this PR to avoid i18n gem update.

@simi simi marked this pull request as ready for review July 13, 2022 14:17
jenshenny
jenshenny approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@jenshenny jenshenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It LGTM!

@sonalkr132 sonalkr132 merged commit 3291e5d into master Jul 14, 2022
@sonalkr132 sonalkr132 deleted the rails-7031 branch July 14, 2022 11:44
@rubygems-org-shipit rubygems-org-shipit bot temporarily deployed to staging July 14, 2022 11:58 Inactive
@rubygems-org-shipit rubygems-org-shipit bot temporarily deployed to production July 14, 2022 12:00 Inactive
@simi
Copy link
Member Author

simi commented Jul 14, 2022

Btw. i18n change was reverted, new versions will not break CI again. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenshenny jenshenny jenshenny approved these changes

@sonalkr132 sonalkr132 sonalkr132 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simi @sonalkr132 @jenshenny