Remove motion-require. #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- juggles the file lists around so they can be reused for subset requires - juggle a couple of load order issues (module before hash, etc) - all the tests run
|
That's awesome, @wndxlori thank you! Glad to see checks passing again, too! |
|
I guess we should bump the version number and get this released, too? Do you want a PR for that, or can you just get that done? I'm thinking at least a 1.2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🤞 final fix for Issue 38, which will make motion-support work properly on High Sierra.
Main feature: rips motion-require out by the roots, and manages class loading/compilation order to 1) make it all work and 2) remove cyclical dependencies.
Minor updates: