CI fixes #300
Merged
CI fixes #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rurban#284 by disabling PMP_Multilinear not only on aarch64, but also on arm64. Those are the same things under different labels.
It's not 100% clear to me if it's UB, CC bug or lack of some kind of memory barrier, but the very same quite innocent-looking code leads to different results on macos-arm64 platform and breaks nmhash32 See rurban#294
--test=VerifyAll, --test=VerifyAll ${hash} and --test=Sanity ${hash} use
the same verification value, so the hashes should start with the same
initialisation code.
That fixes windows build and test=VerifyAll doing Hash_init()
It's unclear to me if it should be `0` (SKIP) or just a value that is quite common across platforms and compilers. See rurban#294
It does not highlight any issues so far, but might come handy in future.
It fixes arm builds, including macos-14-arm64 polymur Verification value 0xA612032C means that polymur_seed_init() was not called. Currently, polymur is compiled in unconditionally, so it should be initialized unconditionally as well. See rurban#294, rurban#296, rurban#297, rurban#298 and rurban#299.
It fixes arm builds, including macos-14-arm64 Verification value 0x9FBDD2B1 for k-hashv32 and 0x70E67C61 for k-hashv64 signal, that the has was not properly seeded. Currently, k-hashv32 and k-hashv64 are compiled depending on HAVE_KHASHV from CMakeLists.txt, so initialization should be done depending on same macro as well. See rurban#294
That fixes aarch64 test=VeryfiAll as umash was built for that platform, but umash_seed_init() was not called due to mismatch in #ifdef's.
The test vectors are `golden128` from https://github.com/golang/go/blob/master/src/hash/fnv/fnv_test.go FNV128("") = 6c62272e07bb014262b821756295c58d FNV128("a") = d228cb69101a8caf78912b704e4a141e FNV128("ab") = 0880945aeeab1be95aa073305526c088 FNV128("abc") = a68bb2a4348b5822836dbc78c6aee73b
rurban
approved these changes
Sep 28, 2024
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's a separate PR accumulating several small fixes for verification value & build failures, as discussed at #293 (comment)
It closes #284, #294 and #296.