Replace anyhow with concrete error type (via thiserror) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also bumped MSRV to 1.65 for let-else. 1.65.0 is >1y old at this point, so it should be fine.
shssoichiro
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added some docs on the public types (
cargo doc --openis still looking a bit sad, I think I might add some docs to yuvxyb).The new MSRV 1.65 was released in November 2022 which should be fine IMHO. It allows us to use let-else syntax which looks a bit nicer than
.map_err(|_| /* our error */)?;The inversion of trait bounds (
T: TryInto<LinearRgb>->LinearRgb: TryFrom<T>) shouldn't cause any problems. It's technically breaking (no-std environments don't have blanketT: TryInto<U>for allU: TryFrom<T>AFAIK) but practically isn't. (I preferred TryFrom over TryInto because it's what yuvxyb actually implements.)The concrete error type is an actual breaking change though.