Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv: ECALL and nested interrupts #169

Merged
merged 2 commits into from
Dec 31, 2023
Merged

riscv: ECALL and nested interrupts #169

merged 2 commits into from
Dec 31, 2023

Conversation

romancardenas
Copy link
Contributor

This PR adds a wrapper to trigger environment calls. It also adds a new function for allowing nested interrupts in M and S mode. Nested interrupts are specially useful for RTOSs, as they can implement preemption in this way.

@romancardenas romancardenas requested a review from a team as a code owner December 28, 2023 11:59
almindor
almindor previously approved these changes Dec 29, 2023
Copy link
Contributor

@almindor almindor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This makes preemption so much nicer, thanks!

@romancardenas
Copy link
Contributor Author

I think I found a 🐛

@almindor can you take a second look?

Copy link
Contributor

@almindor almindor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah the variable == module wording got me a bit confused for a bit. LTGM

@romancardenas romancardenas added this pull request to the merge queue Dec 31, 2023
Merged via the queue into master with commit 0f8305b Dec 31, 2023
58 checks passed
@romancardenas romancardenas deleted the add-ecall branch January 2, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants