Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing defmt impls #881

Merged
merged 1 commit into from
Nov 5, 2024
Merged

add missing defmt impls #881

merged 1 commit into from
Nov 5, 2024

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Nov 3, 2024

@burrbull burrbull requested a review from a team as a code owner November 3, 2024 06:59
Emilgardis
Emilgardis previously approved these changes Nov 3, 2024
View reviewed changes
@burrbull
Copy link
Member Author

burrbull commented Nov 3, 2024

@Emilgardis rebased

@burrbull burrbull mentioned this pull request Nov 3, 2024
Merged
romancardenas
romancardenas approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@romancardenas romancardenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MabezDev
MabezDev approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry I didn't get a chance to make the PR myself 😅

@burrbull
Copy link
Member Author

burrbull commented Nov 4, 2024

@Emilgardis need to update approve.

@Emilgardis Emilgardis added this pull request to the merge queue Nov 5, 2024
Merged via the queue into master with commit e8fddfa Nov 5, 2024
46 checks passed
@Emilgardis Emilgardis deleted the defmt-err branch November 5, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romancardenas romancardenas romancardenas approved these changes

@MabezDev MabezDev MabezDev approved these changes

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TryFromInterruptError doesn't derive Format when defmt is enabled
4 participants
@burrbull @Emilgardis @MabezDev @romancardenas