Update to eslint v9 #2489
Merged
Update to eslint v9 #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
|
I have an alternative using |
Suya1671
reviewed
Apr 6, 2024
No preference on my side, so whichever sounds best to you. |
Switch to using `deno` as that allows referring to the config packages without having to setup a `package.json` and other stuff required when running `eslint` through `node` now.
|
My preference is this approach with deno, it avoids having to manage the whole |
GuillaumeGomez
approved these changes
Apr 7, 2024
|
@Nemo157 @GuillaumeGomez I'm not sure I fully follow, is anything missing here? Or is this ready to be merged? Generally you two can merge too :) |
|
I prefer to let PR owners with merge rights to merge their own PRs once approved so it's waiting on @Nemo157 here. ;) |
syphar
removed
the
S-waiting-on-review
syphar
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Nov 6, 2024
|
Let's merge it then. |
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using
denoas that allows referring to the config packages without having to setup apackage.jsonand other stuff required when runningeslintthroughnodenow.