Rework About/Build #954
Merged
Rework About/Build #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixiron
reviewed
Aug 9, 2020
jyn514
reviewed
Aug 9, 2020
jyn514
reviewed
Aug 9, 2020
|
Should be good now and sorry for the noise :) |
Kixiron
reviewed
Aug 10, 2020
jyn514
reviewed
Aug 12, 2020
|
LGTM once the last few nits are addressed. Could you also squash the commit history a little? |
jyn514
added
the
S-waiting-on-author
- Added a section covering the read-only sandbox file system - Merge sections regarding detection of Docs.rs, also adding examples - Add section covering other build failures - Discuss rebuilds Thanks to jyn514 and Kixiron for their helpful feedback.
|
Done. I've replaced the "Omitting this field means that no README will be displayed." with "If this field is not set, no README will be displayed.". Otherwise it is just a squash including the requested changes. |
|
Thanks so much for the PR! The page is definitely a lot more helpful now :) |
jyn514
added
S-waiting-on-deploy
jyn514
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework About/Build in response to #952