fix must_use_unit suggestion when there're multiple attributes
#13830
+75
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lapla-cogito
commented
Dec 15, 2024
Comment on lines
+110
to
+120
| if attrs.len() == 1 { | ||
| span_lint_and_then( | ||
| cx, | ||
| MUST_USE_UNIT, | ||
| fn_header_span, | ||
| "this unit-returning function has a `#[must_use]` attribute", | ||
| |diag| { | ||
| diag.span_suggestion(attr.span, "remove the attribute", "", Applicability::MachineApplicable); | ||
| }, | ||
| ); | ||
| } else { |
There was a problem hiding this comment.
If this conditional branch is reached and the length of attrs is 1, then it should be #[must_use] and clippy can suggest in the same way as before
|
That's a good improvement, although just finding the span of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12320
When there're multiple attributes, clippy suggests leaving an extra comma and it makes an error.
changelog: [
must_use_unit]: No longer make incorrect suggestions when multiple attributes present.