Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct suggestion for unnecessary_sort_by in no_std #13836

Merged
merged 1 commit into from
Dec 16, 2024
Merged

correct suggestion for unnecessary_sort_by in no_std #13836

merged 1 commit into from
Dec 16, 2024
+62 −3

Conversation

lapla-cogito
Copy link
Contributor

@lapla-cogito lapla-cogito commented Dec 16, 2024 •
edited by llogiq
Loading

fix #11524

In a no_std environment, we can use core::cmp::Reverse instead of std::cmp::Reverse.

changelog: [unnecessary_sort_by]: correct suggestion in no_std

@rustbot
Copy link
Collaborator

rustbot commented Dec 16, 2024

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 16, 2024
@llogiq
Copy link
Contributor

llogiq commented Dec 16, 2024

Thank you!

@llogiq llogiq added this pull request to the merge queue Dec 16, 2024
Merged via the queue into rust-lang:master with commit 063c5c1 Dec 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@llogiq llogiq

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unnecessary_sort_by rule suggests using standard library in no_std program
3 participants
@lapla-cogito @rustbot @llogiq