use the correct ParamEnv
when checking future's output type
#13863
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13862
missing_headers::check
is sometimes called from outside of a body (specifically, fromcheck_attributes
, where the LateContext's ParamEnv is not yet properly initialized for that item). Using that empty ParamEnv for trait solving things from within the body can then lead to various ICEs, like the linked issue where we have a const generic parameterDMA_INST
without aConstArgHasType
bound in the ParamEnv so the const parameter has no type, which is normally not supposed to happen.We have the item's DefId so we can just get its ParamEnv/TypingEnv from there, and using that one for trait solving should be safe.
changelog: none