Nudasnev/shim get set vp state #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NunoDasNeves
requested review from
russell-islam,
liuw and
jinankjain
as code owners
NunoDasNeves
force-pushed
the
nudasnev/shim-get-set-vp-state
branch
8 times, most recently
from
fd00b3d to
22f51ed
Compare
Support BIT() macros containing variables/other defines in LARGE_SNAKE_CASE. Now a constant for HV_HYP_PAGE_SIZE is generated instead of being ignored. Signed-off-by: Nuno Das Neves <[email protected]>
Signed-off-by: Nuno Das Neves <[email protected]>
NunoDasNeves
force-pushed
the
nudasnev/shim-get-set-vp-state
branch
from
22f51ed to
bb03b55
Compare
|
I have been discussing this changes with @NunoDasNeves and we agreed on this. This PR looks good to me. @jinankjain @liuw Could you please look into this? |
I don't have a strong opinion on this. If the three of you agree on a way forward I'm fine with this PR. |
liuw
reviewed
Mar 22, 2024
NunoDasNeves
force-pushed
the
nudasnev/shim-get-set-vp-state
branch
2 times, most recently
from
b43ec6c to
666c5fe
Compare
russell-islam
approved these changes
Mar 25, 2024
|
@NunoDasNeves Please add missing Signed-off-by |
Signed-off-by: Nuno Das Neves <[email protected]>
Rework XSave and LapicState, replace their From<T> implementations to convert to/from Buffer with TryFrom<T>. Replace existing MSHV_GET/SET_VP_STATE implementations with the new kernel interface. Signed-off-by: Nuno Das Neves <[email protected]>
NunoDasNeves
force-pushed
the
nudasnev/shim-get-set-vp-state
branch
from
666c5fe to
7e7820a
Compare
jinankjain
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Make the get/set vp state IOCTLs simpler and easier to use. Remove any interpretation of the XSAVE state, as it is not needed for save/restore.
Replace hv_ definitions in the interface with mshv_ definitions, so the kernel doesn't need to export these.
Use a plain buffer for the data to simplify things.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.