Use Cow<'static, str> for VhostUserDaemon name field. #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the name's type `String` to `Cow<'static, str>`. This allows the library user to prevent string allocation from static strings, which is how most crates use it. This is an API breaking change. Signed-off-by: Manos Pitsidianakis <[email protected]>
epilys
force-pushed
the
trivial/use-cow-for-name
branch
from
cd15176 to
f70b7a3
Compare
epilys
requested review from
eryugey,
jiangliu,
sboeuf,
slp and
stefano-garzarella
as code owners
Ablu
reviewed
Nov 14, 2023
| @@ -124,7 +125,7 @@ where | |||
| mut handler: BackendReqHandler<Mutex<VhostUserHandler<T>>>, | |||
| ) -> Result<()> { | |||
| let handle = thread::Builder::new() | |||
| .name(self.name.clone()) | |||
| .name(self.name.to_string()) | |||
There was a problem hiding this comment.
Hm... This is the only use and requires ownership. So should we maybe just drop it from the daemon struct and make it part of the start_daemon function (as a String that can be moved through)?
Though, overall, I think this is a lot of code churn (for everyone using this) and additional complexity for very little gain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Change the name's type
StringtoCow<'static, str>. This allows thelibrary user to prevent string allocation from static strings, which is
how most crates use it.
This is an API breaking change.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.