Skip to content
This repository has been archived by the owner on Sep 23, 2021. It is now read-only.

Purge FDS on long press #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ojousima
Copy link
Member

This should fix issue where Espruino won't boot when RuuviTag has old data in flash.

@ojousima
Copy link
Member Author

Copy link
Contributor

@DG12 DG12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe toggling LED on each page erase would be helpful especially with no LOG, DEV KIT and Link +JLinkRTTClient is active. Really important if button were to be long pressed by accident!

Does this really warrant version change from 2.5.9 to 2.6.0 rather than 2.5.10 ?

@ojousima
Copy link
Member Author

Maybe toggling LED on each page erase would be helpful especially with no LOG, DEV KIT and Link +JLinkRTTClient is active. Really important if button were to be long pressed by accident!

The erase takes 2 seconds, so led toggling doesn't add a lot of new information.

Does this really warrant version change from 2.5.9 to 2.6.0 rather than 2.5.10 ?

Yes, as it is adding a new functionality. 2.5.10 would be a bugfix in existing functionality.

@DG12
Copy link
Contributor

DG12 commented Jul 24, 2020

Please add a comment in main.c (none since 2.5.6 last year)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants