Revise build.sh, add initial README.md #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yf13
force-pushed
the
revise-build-help
branch
4 times, most recently
from
f7c5da6 to
4604921
Compare
yf13
changed the title
RevySR
reviewed
Mar 1, 2024
build.sh
Outdated
| else | ||
| fault | ||
| fi | ||
| if [ "$1" = "linux" ]; then |
There was a problem hiding this comment.
Please do not modify the main function, this will destroy github action
There was a problem hiding this comment.
Very sorry about that.
How do you think about also updating the .github/workflow/build.yml like below?
- bash ./build.sh build all
+ bash ./build.sh all
There was a problem hiding this comment.
Would like to keep the command categorized
There was a problem hiding this comment.
I see, will update the patch to stick to original usage.
yf13
force-pushed
the
revise-build-help
branch
2 times, most recently
from
d072c37 to
64fd7b7
Compare
Signed-off-by: Yanfeng Liu <[email protected]>
Signed-off-by: Yanfeng Liu <[email protected]>
RevySR
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revises help message of build.sh so that to sync with the code.
It also adds an initial version of README file to help people get started quickly.