Ability to upload using createdPresignedPost #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
scastiel
commented
Feb 5, 2024
| @@ -60,6 +60,7 @@ | |||
| "@aws-sdk/client-s3": ">=3.427.0", | |||
| "@aws-sdk/client-sts": "^3.427.0", | |||
| "@aws-sdk/lib-storage": ">=3.427.0", | |||
| "@aws-sdk/s3-presigned-post": "3.427.0", | |||
There was a problem hiding this comment.
I had to require the exact version, otherwise two versions of S3Client live in the project.
scastiel
commented
Feb 5, 2024
| Key: key, | ||
| Expires: 60 * 60, | ||
| Conditions: [ | ||
| ["content-length-range", 0, 512 * 1024], |
There was a problem hiding this comment.
This part controls the maximum uploaded file size. Obviously, this should be configurable, i.e. it should be possible to send Conditions when using useS3Upload for instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My ultimate need is to be able to set a maximum upload file size. After looking for the best way to do it, it looks like it is possible using
createPresignedPost. It works similarly togetPresignedUrl, but it lets us pass aConditionsparameter that can include thecontent-length-range.This PR is currently more a proof of concept of using
createPresignedPostto upload the file to S3, with a maximum file size. I think this feature doesn’t add too much complexity to the project and could benefit other users.Let me know if you think it’s a good idea, I can work more to make it ready for production (additional testing, documentation update, etc.).