fix(api-kit): Missing to parameter
#1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12008535981Details
💛 - Coveralls |
DaniSomoza
reviewed
Nov 25, 2024
| return sendRequest({ | ||
| url: `${this.#txServiceBaseUrl}/v1/data-decoder/`, | ||
| method: HttpMethod.Post, | ||
| body: { data } | ||
| body: dataDecoderRequest |
There was a problem hiding this comment.
Can we simplify this to?:
body: to ? { to, data } : { data }
DaniSomoza
reviewed
Nov 25, 2024
| * @returns The transaction data decoded | ||
| * @throws "Invalid data" | ||
| * @throws "Not Found" | ||
| * @throws "Ensure this field has at least 1 hexadecimal chars (not counting 0x)." | ||
| */ | ||
| async decodeData(data: string): Promise<any> { | ||
| async decodeData(data: string, to?: string): Promise<any> { |
There was a problem hiding this comment.
Can use this Type instead of Promise<any> ?
type DecodeParameterType = {
name: string
type: string
value: string
}
type DecodeReturnType = {
method: string
parameters: DecodeParameterType[]
}There was a problem hiding this comment.
I don't see the correct type on the service:
https://safe-transaction-sepolia.staging.5afe.dev/#/data-decoder/data_decoder_create
https://github.com/safe-global/safe-transaction-service/blob/f446d55cb527358e5312cea5aa737e0bae1adc6c/safe_transaction_service/history/views.py#L1188-L1225
The return type i'm seeing does not match the { data, to } structure that is in reality the parameters. So not sure if that type is always going to be the one or it can change
DaniSomoza
approved these changes
Nov 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #1046
How this PR fixes it
Adding the
toparameter to thedecodeDatamethod