Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Onchain Identifier via transaction data and calldata fields #1059

Merged
merged 15 commits into from
Dec 16, 2024

Conversation

DaniSomoza
Copy link
Contributor

@DaniSomoza DaniSomoza commented Nov 24, 2024

What it solves

Resolves #1056

How this PR fixes it

Append the on chain identifier to the transaction data field and in the calldata field

Examples

Chain: Sepolia

Safe deployment of a Safe Account (v1.3.0) in Sepolia using the protocol-kit

Safe Deployed: 0x096B2222AE1600D0074d35a8A6BC58FF04AB2384

Transaction Hash: 0xe0192eedd1fc2d06be0561d57380d610dd6d162af0f3cfbd6c08f9062d738761

On-chain Identifier: 5afe006363643438383836663461336661366162653539646561393238653366

Metadata included in the On-chain Identifier:

  • Identifier Prefix: 5afe
  • Identifier Version 00
  • Project: Test Dapp SDK hashed: 6363643438383836663461336661366162653539
  • Platform: Web: hashed: 646561
  • Tool: protocol-kit: hashed: 393238
  • Tool version: 5.0.4: hashed: 653366

Safe transaction of a Safe Account (v1.3.0) in Sepolia using the protocol-kit

Safe used: 0x096B2222AE1600D0074d35a8A6BC58FF04AB2384

the transaction is a rejection tx.

Transaction Hash: 0x0256ef4a2e21c5b529c2b60b3e48327261508d685a24e331788e2ee64275f9b0

On-chain Identifier: 5afe006363643438383836663461336661366162653539646561393238653366

Metadata included in the On-chain Identifier:

  • Identifier Prefix: 5afe
  • Identifier Version 00
  • Project: Test Dapp SDK hashed: 6363643438383836663461336661366162653539
  • Platform: Web: hashed: 646561
  • Tool: protocol-kit: hashed: 393238
  • Tool version: 5.0.4: hashed: 653366

Safe deployment + batch of transactions of a 4337 Safe Account (v1.4.1) in Sepolia using the relay-kit

Safe used: 0xf5E1c84b12763A70c79679ad00d34F0769Be57Cb

the transaction is a deployment of the Safe and a batch of 2 USDC transfers (amount: 0.01 USDC).

Transaction Hash: 0xd8a1a85c7b5ecffe62ba17d02d40f76043566beacb291279aef18242068e1a35

Transaction jiffyscan Link: https://jiffyscan.xyz/userOpHash/0xe1bd646760cf53f0332fec03ef4c094d8132462b1a4258069d7fa8ff08b96657?network=sepolia

On-chain Identifier: 5afe006363643438383836663461336661366162653539646561393063666133

Metadata included in the On-chain Identifier:

  • Identifier Prefix: 5afe
  • Identifier Version 00
  • Project: Test Dapp SDK hashed: 6363643438383836663461336661366162653539
  • Platform: Web: hashed: 646561
  • Tool: relay-kit: hashed: 393063
  • Tool version: 3.2.4: hashed: 666133

@coveralls
Copy link

coveralls commented Nov 24, 2024

Pull Request Test Coverage Report for Build 12350466023

Details

  • 7 of 12 (58.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 75.199%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/relay-kit/src/packs/safe-4337/utils/getRelayKitVersion.ts 2 3 66.67%
packages/relay-kit/src/packs/safe-4337/Safe4337Pack.ts 5 9 55.56%
Totals Coverage Status
Change from base Build 12298877546: -0.3%
Covered Lines: 795
Relevant Lines: 985

💛 - Coveralls

@yagopv yagopv linked an issue Nov 25, 2024 that may be closed by this pull request
@DaniSomoza DaniSomoza changed the title Onchain trackid via transaction data field Onchain indentifier via transaction data and calldata fields Nov 28, 2024
@DaniSomoza DaniSomoza changed the title Onchain indentifier via transaction data and calldata fields feat: Onchain Identifier via transaction data and calldata fields Nov 28, 2024
@DaniSomoza DaniSomoza requested a review from yagopv November 28, 2024 14:01
@yagopv yagopv linked an issue Dec 2, 2024 that may be closed by this pull request
@yagopv
Copy link
Member

yagopv commented Dec 11, 2024

onchainAnalitics variable should be onchainAnalytics across the code :)

@yagopv yagopv merged commit de4f1de into development Dec 16, 2024
19 checks passed
@yagopv yagopv deleted the onchain-trackid-data branch December 16, 2024 12:56
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Onchain tracking] Implementation [Onchain tracking] PoC
4 participants