-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Onchain Identifier via transaction data
and calldata
fields
#1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12350466023Details
💛 - Coveralls |
Closed
DaniSomoza
changed the title
Onchain trackid via transaction data field
Onchain indentifier via transaction Nov 28, 2024
data
and calldata
fields
DaniSomoza
changed the title
Onchain indentifier via transaction
feat: Onchain Identifier via transaction Nov 28, 2024
data
and calldata
fieldsdata
and calldata
fields
This was referenced Dec 2, 2024
Closed
yagopv
reviewed
Dec 2, 2024
packages/protocol-kit/src/utils/on-chain-tracking/generateOnChainIdentifier.ts
Outdated
Show resolved
Hide resolved
yagopv
reviewed
Dec 2, 2024
yagopv
reviewed
Dec 2, 2024
yagopv
reviewed
Dec 2, 2024
yagopv
reviewed
Dec 2, 2024
yagopv
reviewed
Dec 2, 2024
yagopv
reviewed
Dec 2, 2024
yagopv
reviewed
Dec 2, 2024
germartinez
reviewed
Dec 9, 2024
packages/protocol-kit/src/utils/on-chain-tracking/generateOnChainIdentifier.ts
Outdated
Show resolved
Hide resolved
|
yagopv
approved these changes
Dec 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #1056
How this PR fixes it
Append the on chain identifier to the transaction
data
field and in thecalldata
fieldExamples
Chain:
Sepolia
Safe deployment of a Safe Account (
v1.3.0
) in Sepolia using theprotocol-kit
Safe Deployed:
0x096B2222AE1600D0074d35a8A6BC58FF04AB2384
Transaction Hash:
0xe0192eedd1fc2d06be0561d57380d610dd6d162af0f3cfbd6c08f9062d738761
On-chain Identifier:
5afe006363643438383836663461336661366162653539646561393238653366
Metadata included in the On-chain Identifier:
5afe
00
Test Dapp SDK
hashed:6363643438383836663461336661366162653539
Web
: hashed:646561
protocol-kit
: hashed:393238
5.0.4
: hashed:653366
Safe transaction of a Safe Account (
v1.3.0
) in Sepolia using theprotocol-kit
Safe used:
0x096B2222AE1600D0074d35a8A6BC58FF04AB2384
the transaction is a rejection tx.
Transaction Hash:
0x0256ef4a2e21c5b529c2b60b3e48327261508d685a24e331788e2ee64275f9b0
On-chain Identifier:
5afe006363643438383836663461336661366162653539646561393238653366
Metadata included in the On-chain Identifier:
5afe
00
Test Dapp SDK
hashed:6363643438383836663461336661366162653539
Web
: hashed:646561
protocol-kit
: hashed:393238
5.0.4
: hashed:653366
Safe deployment + batch of transactions of a 4337 Safe Account (
v1.4.1
) in Sepolia using therelay-kit
Safe used:
0xf5E1c84b12763A70c79679ad00d34F0769Be57Cb
the transaction is a deployment of the Safe and a batch of 2
USDC
transfers (amount:0.01 USDC
).Transaction Hash:
0xd8a1a85c7b5ecffe62ba17d02d40f76043566beacb291279aef18242068e1a35
Transaction jiffyscan Link: https://jiffyscan.xyz/userOpHash/0xe1bd646760cf53f0332fec03ef4c094d8132462b1a4258069d7fa8ff08b96657?network=sepolia
On-chain Identifier:
5afe006363643438383836663461336661366162653539646561393063666133
Metadata included in the On-chain Identifier:
5afe
00
Test Dapp SDK
hashed:6363643438383836663461336661366162653539
Web
: hashed:646561
relay-kit
: hashed:393063
3.2.4
: hashed:666133