Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zksync flag to contract deployment #640

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Add zksync flag to contract deployment #640

merged 1 commit into from
Nov 6, 2024

Conversation

valle-xyz
Copy link
Collaborator

@valle-xyz valle-xyz commented Nov 6, 2024

Adds an optional flag to inform about an env variable needed to deploy ZKsync chains.

Replaces #639

Copy link

github-actions bot commented Nov 6, 2024

Branch preview

✅ Deployed successfully in branch deployment:

https://zksyncfix--docs.review.5afe.dev

Copy link

github-actions bot commented Nov 6, 2024

Overall readability score: 30.96 (🟢 +0)

File Readability
safe-contracts-deployment.mdx 52.98 (🟢 +0)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
safe-contracts-deployment.mdx 52.98 40.14 8.24 14.4 14.84 7.58
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0

Averages:

  Readability FRE GF ARI CLI DCRS
Average 30.96 26.38 13.5 18.06 15.94 8.78
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

@tanay1337 tanay1337 merged commit bf42fc7 into main Nov 6, 2024
4 checks passed
@tanay1337 tanay1337 deleted the zkSyncFix branch November 6, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants