block entities servux paste #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if you think this is good enough for review. |
|
I did not change a lot on litematica, currently this works well. review this please, and servux as well |
|
I found a Servux side issue for this with the Packet Splitter. It's not a "bug" but it's more of a "we need to allow Packet Splitter to receive larger slices from a Client" issue. |
|
All set for merge |
sakura-ryoko
merged commit 6c82dee
into
sakura-ryoko:pre-rewrite/fabric/1.21-block_entities
2 checks passed
sakura-ryoko
added a commit
that referenced
this pull request
Jul 3, 2024
* Bootstrap for entity data * Fix data channel for servux * block entities servux paste (#3) * feat: paste to servux * feat: paste to servux * feat: paste to servux * fix * Forgot to merge my fixes * Forgot to merge my fixes * Fix Accurate Placement for Crafter Orientations and a few other Block States * Update accuratePlacement Protocol V3 for use with Servux * Fix: Item Frame floor / ceiling Yaw values. * Add settings for Entity Data Syncer * Add settings for Entity Data Syncer * code cleanup / Litematic Entity NBT Save handling * code cleanup / Litematic Entity NBT Save handling --------- Co-authored-by: Liyan Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.