Skip to content

Commit

Permalink
restore otel method name
Browse files Browse the repository at this point in the history
  • Loading branch information
lkostrowski committed Dec 6, 2023
1 parent f11be4f commit e164d6a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/early-mails-explain.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@saleor/app-sdk": patch
---

Removed OTEL attribute http.method. It eventually caused bad mapping in Datadog -> overwriting span name
2 changes: 0 additions & 2 deletions src/APL/saleor-cloud/saleor-cloud-apl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ export class SaleorCloudAPL implements APL {
attributes: {
saleorApiUrl,
[SemanticAttributes.PEER_SERVICE]: OTEL_APL_SERVICE_NAME,
[SemanticAttributes.HTTP_METHOD]: "GET",
},
kind: SpanKind.CLIENT,
},
Expand Down Expand Up @@ -269,7 +268,6 @@ export class SaleorCloudAPL implements APL {
saleorApiUrl: authData.saleorApiUrl,
appId: authData.appId,
[SemanticAttributes.PEER_SERVICE]: OTEL_APL_SERVICE_NAME,
[SemanticAttributes.HTTP_METHOD]: "POST",
},
kind: SpanKind.CLIENT,
},
Expand Down

0 comments on commit e164d6a

Please sign in to comment.