Approximate sizes of stack
and visisted
when collecting accumulated values
#622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the input-output length to approximate the number of items added to
stack
and reservesstack.len()
additional items invisited
to avoid costly resizes. This reduces the performance regression in astral-sh/ruff#14760 from 10.3% to 9%, which seems worthwhile.The downside is that it can result in a too large
stack
if a query has many outputs but only few outputs or in a too largevisited
set if many inputs are overlapping. I think this is acceptable, considering that the data structures are short-lived.Performance
This shows a 9% performance improvement for the accumulator benchmark.