Shrink QueryRevisions size by 3 words
#636
Draft
+70
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #636 will not alter performanceComparing Summary
|
|
I wonder if #629 would help here a bit by reducing the need to allocate additionally (or whether the cause of the perf regression is the extra indirection) |
|
I haven't reviewed the code changes but any chance you undid the optimization introduced in #615 |
|
Ah I believe I did by accident! |
Veykril
force-pushed
the
veykril/push-accumulated
branch
from
98d7005 to
d0b5fd4
Compare
Veykril
force-pushed
the
veykril/push-accumulated
branch
from
d0b5fd4 to
96d7780
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.