Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for errorfiles in listen and backend blocks and more global ssl settings #80

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

darix
Copy link

@darix darix commented Aug 1, 2019

No description provided.

@aboe76
Copy link
Member

aboe76 commented Aug 1, 2019

@darix can you also update the pillar.example with an example?

@darix
Copy link
Author

darix commented Aug 1, 2019 via email

@aboe76
Copy link
Member

aboe76 commented Aug 1, 2019

@darix no need to copy, just make a reference so they know they can use it there as well

@darix darix force-pushed the add_support_for_errorfiles_in_listens_and_backends branch from efa90ce to 53ab2f1 Compare March 2, 2022 21:59
@darix darix requested a review from daks as a code owner March 2, 2022 21:59
@darix
Copy link
Author

darix commented Mar 2, 2022

@darix no need to copy, just make a reference so they know they can use it there as well

done

@darix darix changed the title Add support for errorfiles in listen and backend blocks Add support for errorfiles in listen and backend blocks and more global ssl settings Mar 2, 2022
@darix darix force-pushed the add_support_for_errorfiles_in_listens_and_backends branch from 6d5380c to 33f4d7e Compare March 11, 2022 22:05
@aboe76
Copy link
Member

aboe76 commented Mar 11, 2022

@daks will you please take a look?

@darix
Copy link
Author

darix commented Mar 11, 2022

JFYI: working on the next feature already. But this is still untested:

darix@84e37f3

this ugly code is needed because salt mine doesnt work within a pillar sls file.

need to learn how to do a helper within a formular. so i can remove all the code duplication between listens and backends.

Copy link
Member

@daks daks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darix Looks good to me. Your commit messages needs some changes though, please look at https://github.com/saltstack-formulas/template-formula/tree/master/docs#contributing-to-this-repo

It would have been great to test those features in Inspec but at the moment those tests are already minimal...

update: I tested debian-11/10/9 on 3004-py3 and all fine 👍

@daks
Copy link
Member

daks commented Mar 22, 2022

JFYI: working on the next feature already. But this is still untested:

darix@84e37f3

this ugly code is needed because salt mine doesnt work within a pillar sls file.

need to learn how to do a helper within a formular. so i can remove all the code duplication between listens and backends.

what are you trying to do with this code? Retrieving items via salt mine?

If it's the case, and you need inspiration, you can look at how openssh-formula or mysql-formula do it, see https://github.com/saltstack-formulas/openssh-formula/blob/master/openssh/files/default/ssh_known_hosts https://github.com/saltstack-formulas/mysql-formula/blob/master/mysql/user.sls. (those are just examples and may not correspond to your particular need)

@darix
Copy link
Author

darix commented Mar 22, 2022

JFYI: working on the next feature already. But this is still untested:
darix@84e37f3
this ugly code is needed because salt mine doesnt work within a pillar sls file.
need to learn how to do a helper within a formular. so i can remove all the code duplication between listens and backends.

what are you trying to do with this code? Retrieving items via salt mine?

If it's the case, and you need inspiration, you can look at how openssh-formula or mysql-formula do it, see https://github.com/saltstack-formulas/openssh-formula/blob/master/openssh/files/default/ssh_known_hosts https://github.com/saltstack-formulas/mysql-formula/blob/master/mysql/user.sls. (those are just examples and may not correspond to your particular need)

I have the salt mine stuff implemented now.

I was wondering actually if I could just merge it into this PR or if you want a separate one.

Full diff darix/haproxy-formula@master...add_salt_mine_support
Relative diff to this branch/PR darix/haproxy-formula@add_support_for_errorfiles_in_listens_and_backends...add_salt_mine_support

@daks
Copy link
Member

daks commented Mar 22, 2022

I think a separate PR is better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants