Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dark Mode Button #99

Closed
wants to merge 1 commit into from

Conversation

manishprivet
Copy link

I added a Dark Mode button for #56

Right now, I am having problems regarding the UI design of the button and I need some help with it.

For now, this button can be used to toggle CSS variables in the root element and persisting data in the local storage, as discussed in #56.

Can someone let me know if there are any design guidelines/Figma link that I should follow on designing the button?

@anandbaburajan
Copy link
Member

Can someone let me know if there are any design guidelines/Figma link that I should follow on designing the button?

We don't have any design guidelines unfortunately. Would you like to suggest something? The button could be an icon right? Maybe this https://icons.getbootstrap.com/icons/sun-fill/ and the Moon for the dark mode?

@anandbaburajan
Copy link
Member

Also, please check your code after linting. You can simply setup automatic linting in vscode too.

@anandbaburajan anandbaburajan added gssoc21 enhancement New feature or request UI labels Mar 10, 2021
@anandbaburajan
Copy link
Member

@VipinVIP I'm assigning you to look over this feature and assist Manish with doubts/suggestions. Thanks to both of you!

Copy link
Contributor

@VipinVIP VipinVIP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked out the work you did . Since its work in progress , i recommend you to continue adding changes and pushing it. 😇

@manishprivet
Copy link
Author

Thanks @VipinVIP @anandbaburajan .

Yeah, it's unfinished work right now, and I'll push more changes to it, starting with changing that button to an icon.

@anandbaburajan
Copy link
Member

Closing this since we would need to rework on this when we move to Tailwind, but thank you @manishprivet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants