Update contentInset properly, set a specific size for the pull to refresh view #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update contentInset properly, set a specific size for the pull to refres...
Fix crash related with content inset observer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @samvermette,
Here's a pull to request to update the value of the contentInset when it's modified after the pull to refresh view has been created.
(Alternative implementation would be to add a method to update originalInsetTop and originalInsetBottom).
Also, I hardcoded a new value for the size of the pull to refresh view. Of course, that's probably not the right thing to do. Do you recommend a way to move forward to be able to customize its size?
My goal when changing the size was to move the arrow outside of the screen since I changed the contentInset value of my table view.